BIND 10 #588: bindctl traceback on shutdown
BIND 10 Development
do-not-reply at isc.org
Wed Mar 9 13:35:25 UTC 2011
#588: bindctl traceback on shutdown
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: vorner
Type: defect | Status: reviewing
Priority: minor | Milestone: A-Team-
Component: bind- | Sprint-20110309
ctl | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by zzchen_pku):
* owner: zzchen_pku => vorner
Comment:
Replying to [comment:5 vorner]:
> Shouldn't this have some tests? Not that I would have an idea how to
test it, but some kind would be nice.
Since the bug was rised by
{{{
status, reply_msg = self._send_message(url, body)
}}}
I rewrite cmdloop() logic, hope it make sense, or any better suggestions?
> Shouldn't this have a changelog entry?
I think it should have one, please find below:
{{{
193. [bug] jerry
src/bin/bindctl: bindctl shouldn't show traceback on shutdown.
(Trac #588, git TDB)
}}}
> It may be misleading to think that it just happily terminated. We should
know when submitting of the command failed because there was noone to
submit to (either by a traceback or some error message).
Updated, interactive and non-interactive mode will show different log
message.
> I also fixed one space, which wasn't by the recommended code style.
Thanks.
--
Ticket URL: <http://bind10.isc.org/ticket/588#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list