BIND 10 #610: Stop/Start/Run tests of b10-auth

[BIND 10 Development]

#610: Stop/Start/Run tests of b10-auth
-------------------------------------+-------------------------------------
                 Reporter:  stephen  |                Owner:  jinmei
                     Type:  task     |               Status:  reviewing
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110316
  b10-auth                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  3.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 vorner]:
 > Hello
 >
 > Replying to [comment:9 jinmei]:
 > > >  - Should there be some tests for the command line parsing? (for
 bindctl)
 > >
 > > I may misunderstand it, but I think such tests should go to bindctl
 itself.
 >
 > Well, they should go to bindctl's tests, sure. But my question was about
 if it would be possible to test if parsing the arguments work (because you
 added new argument --csv-file-dir). But on the other hand, it is tested
 kind of implicitly in the tests you just added, so it's probably not
 really critical.

 Ah, okay.  I was confused with the command sequence to bindctl (via
 echo and pipe) used in the system tests.

 For the command line option to bindctl, yes, I was aware that it was
 missing and should ideally be tested explicitly.  I skipped the test
 partly because (as you mentioned) it was indirectly tested through the
 system test, and partly because it seemed to require larger
 refactoring as option parsing was part of __main__.  On looking at it
 again, however, I found it not that difficult; we can use
 set_bindctl_options() for testing.

 So, according to the "we shouldn't allow an easy excuse of skipping
 tests" principle, I added tests for the option.  For that I had to
 rename "bindctl-source.py", but the original name didn't seem to be a
 good one anyway, so renaming itself may also make sense.

 Please let me know if this change is okay and if there's anything else
 I should address.

-- 
Ticket URL: <http://bind10.isc.org/ticket/610#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development