BIND 10 #658: Check qid of responses

[BIND 10 Development]

#658: Check qid of responses
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  UnAssigned
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  resolver                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 Ready for review, though there are a few TODO's, mostly related to the
 deferred decision where to actually put the check (if we do it in
 something like a demuxer we may habe put the data in a buffer already, and
 don't need the copied readUint16 for instace, and if we do need that copy,
 we should move the implementation to a util/compat lib).

 - added writeUint8At to buffer (needed for a test, but seemed useful in
 general)

 does *not* check the address at this point, since we already do a
 receiveFrom, the only thing we could check would be that we would check
 whether the address we entered was equal to the address we entered, which
 seems a bit superfluous :)

 did add 2 tests; one to see it does ignore bad qid responses, and one to
 see that once it has ignored it, it will in fact accept a second (correct)
 response.

-- 
Ticket URL: <http://bind10.isc.org/ticket/658#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development