BIND 10 #658: Check qid of responses

[BIND 10 Development]

#658: Check qid of responses
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  jelte
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  resolver                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 '''src/lib/dns/buffer_unittest.cc'''[[BR]]
 Should add a EXPECT_THROW test to check that the exception is thrown if
 the position specified is invalid.

 '''src/lib/asiolink/io_fetch.cc'''[[BR]]
 The recently merged ticket #499 includes "asiolink_utilities", which
 provides a readUint16 function.

 I think it would be more elegant to put the QID check in a separate method
 which does the check and prints the error message (instead of an explicit
 test inlie and a "break" to get out of the loop), i.e.
 {{{
 do {
    do {
       asyncReceive
    } while (!receiveComplete)
 } while (!qidMatches)
 }}}

 We do need the address check.  The endpoint passed to open() and
 asyncSend() is is the address to where the data is being sent.  The
 endpoint returned from asyncReceive() is the address from which the
 response was received.  (These may be different when UDP is used.)  At
 present, IOFetch is incorrect in that it uses the same variable for both:
 it should use a separate one for the returned address.

-- 
Ticket URL: <https://bind10.isc.org/ticket/658#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development