BIND 10 #615: custom configurations, ports,

[BIND 10 Development]

#615: custom configurations, ports,
-------------------------------------+-------------------------------------
                 Reporter:  jreed    |                Owner:  jinmei
                     Type:  task     |               Status:  accepted
                 Priority:  major    |            Milestone:  A-Team-
                Component:           |  Sprint-20110316
  Unclassified                       |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 '''general comments'''

 It was not clear what if both config-file and data-path are specified
 and the former is absolute.  I finally found the answer in the pydoc
 for cfgmr lib, but it should be nicer if it's also clarified in man
 pages.

 But I have a more fundamental question: why do we have to separate
 data-path and config-file?  Unless data-path is used for other
 purposes than the path to config-file, it should be much simpler if we
 only have config-file (which should include the path).  Then we
 wouldn't even bother to consider/document the conflicting case.  After
 reading the entire diff, I'm still not sure how/whether data-path can
 be used for a different purpose.

 I've also fixed minor editorial issues and directly pushed the change.

 '''bind10.py'''
 - In BoB.__init__, maybe a bit more explanation about the two new
 parameters?
 - start_cfgmr(): maybe "args" is better than "opts"? (this variable is
   not only for options).  same for start_cmdctl.

 '''bind10.xml'''
 s/bind/BIND/?  Actually, I was not sure what "bind" means here...can
 that also be used for other programs than cfgmgr?
 {{{
           <para>The path where bind looks for configuration files.</para>
 }}}

 '''bind10_test.py'''
 - I'd test missing option parameter cases, too.

 '''b10-cfgmgr.py.in'''
 - I personally think '-c' is more common for specifying a config file
   (and it's more consistent with other BIND programs)
 - maybe add space around '+' for readability?
 {{{
 +                      "(default="+DATA_PATH+")", default=DATA_PATH)
 }}}
 - I'd explicitly define a constant than hardcoding the default in the
   main code:
 {{{
                       "(default=b10-config.db)", default="b10-config.db")
 }}}

 '''lib/config/cfgmgr.py'''
 - I think we should generally cleanup hardcoded "b10-config.db" from
   this file (now that we have the ability to specify it)
 - not specific to this patch, but this doc should probably be updated
  so that it doesn't hardcode "b10-config.db":
 {{{
 class ConfigManager:
     """Creates a configuration manager. The data_path is the path
        to the directory containing the b10-config.db file.
 }}}

 '''lib/.../cfgmgr_test.py'''
 - TestConfigManager.test_paths: it would be better to use os.sep than '/'

-- 
Ticket URL: <http://bind10.isc.org/ticket/615#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development