BIND 10 #493: Negative cache
BIND 10 Development
do-not-reply at isc.org
Fri Mar 11 12:22:44 UTC 2011
#493: Negative cache
-------------------------------------+-------------------------------------
Reporter: shane | Owner: ocean
Type: | Status: reviewing
enhancement | Milestone: R-Team-
Priority: major | Sprint-20110316
Component: | Resolution:
resolver | Sensitive: 0
Keywords: | Add Hours to Ticket: 0
Estimated Number of Hours: 5.0 | Total Hours: 0
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => ocean
Comment:
>> '''src/lib/cache/message_utility.{cc,h}'''[[BR]]
>> hasTheRecordInAuthoritySection(): I suggest that a comment be added
noting that you just need to know about the presence of an SOA record but
don't know what name it will be associated with, which is why
Message::hasRRset is not used.
> Done. Add a comment. This is because that the
isc::dns::Message:hasRRset() is not const-qualified.
OK - I've added ticket #688 to address this.
>> Suggest tests with different SOA records...
I'm afraid my comment was due to a mis-reading of
[http://tools/ietf.org/html/rfc2308 RFC 2308]: use of the SOA minimum
field applies to authoritative servers and is concerned with setting the
TTL of the record in the response. So you are right in just taking the
TTL of the returned SOA record and limiting it to a maximum value.
All looks OK, please merge.
--
Ticket URL: <https://bind10.isc.org/ticket/493#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list