BIND 10 #588: bindctl traceback on shutdown

[BIND 10 Development]

#588: bindctl traceback on shutdown
-------------------------------------+-------------------------------------
                 Reporter:  jreed    |                Owner:  zzchen_pku
                     Type:  defect   |               Status:  reviewing
                 Priority:  minor    |            Milestone:  A-Team-
                Component:  bind-    |  Sprint-20110316
  ctl                                |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => zzchen_pku


Comment:

 Hello

 I noticed that the test was actually broken. You executed the precmd
 before calling assertRaises, so it's result got passed to it. It then
 tried to call it instead of the tested function. And None as an exception
 seems to mean it throws something and I don't care what, so when it tried
 to call the return value, the check was happy, because it threw that this
 is not callable.

 I didn't find a function that checks it doesn't throw anything, so I left
 the call just outside anything. It would make the test fail as well if it
 was broken.

 So, if you agree with this change, it can be merged.

 Anyway, not directly related to this ticket, I noticed that no our code
 calls onecmd and precmd. Do you have an idea what calls them? Just out of
 curiosity?

 Thanks

-- 
Ticket URL: <https://bind10.isc.org/ticket/588#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development