BIND 10 #80: review: auth server incorrectly returns SERVFAIL to queries of class ANY

[BIND 10 Development]

#80: review: auth server incorrectly returns SERVFAIL to queries of class ANY
-------------------------------------+-------------------------------------
                 Reporter:  jinmei   |                Owner:  jinmei
                     Type:  defect   |               Status:  reviewing
                 Priority:           |            Milestone:  A-Team-
  critical                           |  Sprint-20110316
                Component:           |           Resolution:
  b10-auth                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:
Estimated Number of Hours:  5.0      |          Total Hours:
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 It seems g++ doesn't like passing a function-local class as a template
 argument, I'm not sure if this is OK by the standard or it is a bug. But
 I've taken the class outside, since it's a .cc file anyway, so it won't
 spam much of a namespace.

 Secondly, there are things like this:
 {{{
 RRsetPtr cname_rrset = findRRsetFromList(syn,
                                          RRType::CNAME());
 addToMessage(q, Message::SECTION_ANSWER, cname_rrset);
 chaseCname(q, task, cname_rrset);
 }}}

 As I get it, findRRsetFromList can return null pointer. Are the other
 functions expected to handle it? Or, is it so it can't happen in these
 cases that the type would be missing?

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/80#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development