BIND 10 #615: custom configurations, ports,
BIND 10 Development
do-not-reply at isc.org
Mon Mar 14 19:41:27 UTC 2011
#615: custom configurations, ports,
-------------------------------------+-------------------------------------
Reporter: jreed | Owner: jinmei
Type: task | Status: reviewing
Priority: major | Milestone: A-Team-
Component: | Sprint-20110316
Unclassified | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:19 vorner]:
> There wasn't problem I would consider it too much work, it's not that
much, I just did that. I wasn't sure if we want to do it, when the tests
use it.
Whan a sensible change requests an update to some tests, IMO we should
change the tests as well as the main code. So the question is the
change to the main code is sensible, and in this case I thought so.
If you were okay with the code change itself, I believe it should be
okay to update the test.
I also confirmed the default file name is tested in the daemon test,
which is good (we've not lost test cases for checking whether we use
the correct default).
> So, is this OK as well?
Yes. I'm now okay to merge it.
--
Ticket URL: <https://bind10.isc.org/ticket/615#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list