BIND 10 #363: "H" and "I" are probably harmful for PyArg_ParseTuple()
BIND 10 Development
do-not-reply at isc.org
Mon Mar 14 22:32:33 UTC 2011
#363: "H" and "I" are probably harmful for PyArg_ParseTuple()
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: UnAssigned
Type: defect | Status: reviewing
Priority: minor | Milestone: A-Team-
Component: | Sprint-20110316
DNSPacket API | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 0.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:6 zzchen_pku]:
> Branch #363 is ready for review.
It didn't pass a test for me:
{{{
Running test: message_python_test.py
..........E...........
======================================================================
ERROR: test_header_flag (__main__.MessageTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/jinmei/src/isc/git/bind10-363/src/lib/dns/python/tests/message_python_test.py",
line 114, in test_header_flag
self.assertRaises(TypeError, self.r.set_header_flag, 0x80000000)
File
"/opt/local/Library/Frameworks/Python.framework/Versions/3.1/lib/python3.1/unittest.py",
line 589, in assertRaises
callableObj(*args, **kwargs)
OverflowError: Message header flag out of range
}}}
Also, it was not clear to me why you chose long (instead of int) in
some cases while choosing int for others. Please clarify the
rationale.
(Note: as a test failed I've not looked at the code so closely yet)
--
Ticket URL: <http://bind10.isc.org/ticket/363#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list