BIND 10 #658: Check qid of responses

[BIND 10 Development]

#658: Check qid of responses
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  jelte
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  resolver                           |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 '''src/lib/asiolink/io_fetch.h'''[[BR]]
 IOFetchData constructor: remote_rcv should be initialized in the same way
 as remote_snd.  Because both are shared pointers, by initializing via the
 copy constructor, both point to the same underlying IOEndpoint.

 '''src/lib/asiolink/io_fetch.h'''[[BR]]
 responseOK: remote_snd and remote_rcv are shared pointers, so they should
 be dereferenced before checking for equality: the check should be:
 {{{
 *data.remote_snd == *data.remote_rcv
 }}}

 operator(): Note: when you merge, there are changes around the call to
 open.

 > I also added an operator==() and operator!=() to IOAddress (+tests), and
 > responseOK() checks that.
 The changes don't appear to be in the commit (and besides, remote_xxx are
 pointers to IOEndpoints, not IOAddresses).

-- 
Ticket URL: <https://bind10.isc.org/ticket/658#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development