BIND 10 #643: Memory leaks in the cache

[BIND 10 Development]

#643: Memory leaks in the cache
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  zhanglikun
                     Type:  defect   |               Status:  closed
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  Unclassified                       |           Resolution:  fixed
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by zhanglikun):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:8 jelte]:
 > Only one slight comment, the 'left the size of the list 0' seems a bit
 off; should this be something like "When done, the size of the list will
 be 0"? (it occurs at least twice in lru_list.h).

 Done, Thanks

 >
 > Oh and just a question (i think the answer is yes), is it safe to call
 the drop handler from the lru_list (are we sure we cannot do this while
 the entry is somehow still in the hash table?)
 >

 Yes, it's safe, since the drop handler is tranferred from hash table,
 currently lru list and hash table are seperate, there is one ticket about
 merging them together. When one entry is removed from lru list, it has to
 be removed from hash table, or else, the entry will never be deleted(also
 we have no way to iterate hash table).


 > If the answer is yes, and you clarify the comment, I think this is good
 and can be merged (i don't see any valgrind problems anymore in
 cache/tests)

 Done, thanks, see git aba4c4067da0dc63c97c6356dc3137651755ffce.

-- 
Ticket URL: <http://bind10.isc.org/ticket/643#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development