BIND 10 #678: UDPServer and TCPServer classes need clenup and tests.

[BIND 10 Development]

#678: UDPServer and TCPServer classes need clenup and tests.
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  hanfeng
                     Type:  defect   |               Status:  reviewing
                 Priority:           |            Milestone:  A-Team-
  critical                           |  Sprint-20110316
                Component:           |           Resolution:
  Unclassified                       |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  0.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------

Comment (by hanfeng):

 Replying to [comment:4 vorner]:
 > Hello
 >
 >  - Timeouts in tests are generally bad and these are pretty long ones,
 slowing down the whole test process. Would it be possible to do it without
 them or at last have them shorter?
 The timeout is quit long, I have shorten them so that they won't slow the
 whole tests

 >  - If it fails the test, it will block forever. That isn't good for our
 automated tests.
 Since we have to build client and server environment, and io service run
 revoke is blocking , so I add another thread to make sure even stop
 interface doesn't work, it won't block followed tests.

 >  - The tests look quite heavy-weight (eg. quite a lot of code). Not that
 I'd have an idea how to simplify/shorten it, but it would be nice, if
 reasonably possible.
 I have refine the test code, hope it looks a little shorter and simpler,
 :)
 Although the test is mainly focus on stop interface, it also test the
 whole dns server logic, so the code
 worth its size.

 >  - Your code seems to be based on something slightly out of date. The
 cycle inside the operator (), checking for while (ec) already handles
 errors (not only bad socket ones) in master, based on the bugfix #657.
 Would you mind merging these together and resolving the collisions that
 will happen there?
 I have merged the code and since your code covered bad descriptor check so
 I remove my check.

 >  - What does „default“ in changelog entry mean? And it is not true the
 interface changed (the interface is the same, the internal handling
 changed), and as there are mostly tests added, is the user > Thanks
 You are right, this ticket may be not worth a change log entry, I have
 remove it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/678#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development