BIND 10 #678: UDPServer and TCPServer classes need clenup and tests.
BIND 10 Development
do-not-reply at isc.org
Tue Mar 15 20:29:01 UTC 2011
#678: UDPServer and TCPServer classes need clenup and tests.
-------------------------------------+-------------------------------------
Reporter: vorner | Owner: hanfeng
Type: defect | Status: reviewing
Priority: | Milestone: A-Team-
critical | Sprint-20110316
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Add Hours to Ticket: 0
Estimated Number of Hours: 0.0 | Total Hours: 0
Billable?: 1 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => hanfeng
Comment:
Hello
Replying to [comment:5 hanfeng]:
> > - If it fails the test, it will block forever. That isn't good for
our automated tests.
> Since we have to build client and server environment, and io service run
revoke is blocking , so I add another thread to make sure even stop
interface doesn't work, it won't block followed tests.
Most of the changes look ok. But there's a problem:
{{{
run_unittests_LDFLAGS = $(AM_LDFLAGS) $(GTEST_LDFLAGS) -lboost_thread
}}}
You link against a boost library. We decided we don't want to link against
that I believe. We will have to live without it or bring it to mailling
list for discussion. I know threads are handy sometimes and we will need
them for something in future I believe, but why isn't alarm enough? It
seems simpler to me (though it would provide less informative error
message if it kills the test process). Or some fork trick?
Thanks
--
Ticket URL: <http://bind10.isc.org/ticket/678#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list