BIND 10 #641: Memory leaks in NSAS

[BIND 10 Development]

#641: Memory leaks in NSAS
-------------------------------------+-------------------------------------
                 Reporter:  vorner   |                Owner:  vorner
                     Type:  defect   |               Status:  reviewing
                 Priority:  major    |            Milestone:  R-Team-
                Component:           |  Sprint-20110316
  Unclassified                       |           Resolution:
                 Keywords:           |            Sensitive:  0
Estimated Number of Hours:  0.0      |  Add Hours to Ticket:  0
                Billable?:  1        |          Total Hours:  0
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 > Anyway, in case we delete them both, the resolver should make sure all
 the pending callbacks are called, just like in the test resolver. But as
 this happens on shutdown only now, we probably can leave it out for now.
 Fair enough.  But as a future task should we also add the callbacks to a
 list inside the NSAS such that the NSAS destructor can call them?
 Alternatively, do we really need there to be a shared_ptr loop involving
 the callbacks, even if it is broken when they are called?


 > In nameserver_address_store.cc ... There's no longer need to have double
 pointer to the resolver once the there's no shared pointer.
 Removed.

 > The exceptions of random number generator ... Maybe that common ancestor
 should also be subclass of !InvalidParameter? or !BadValue?.
 The exceptions are now derived from !BadValue.

 > Is it OK to have no changelog entry? Maybe yes, because the resolver
 didn't really exist in the previous releases in usable state, so a memory
 leak in the tests wasn't a bug worth noting.
 That was my thought - it is a change invisible to the user.

 Changes pushed as commit 788d9505e0bec5369ccecc6f51af957874063fd8

-- 
Ticket URL: <http://bind10.isc.org/ticket/641#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development