BIND 10 #697: b10-resolver crashed on parsing answer (server failed: additional too short)

[BIND 10 Development]

#697: b10-resolver crashed on parsing answer (server failed: additional too
short)
-------------------------------------+-------------------------------------
                 Reporter:  jelte    |                Owner:  stephen
                     Type:  defect   |               Status:  reviewing
                 Priority:           |            Milestone:  R-Team-
  critical                           |  Sprint-20110316
                Component:           |           Resolution:
  resolver                           |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  0.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => stephen


Comment:

 Replying to [comment:4 stephen]:
 > '''src/lib/resolve/tests/recursive_query_unittest_2.cc'''[[BR]]
 > The !QueryStatus enum should have explicit values assigned to each
 member according to the CodingGuidelines.

 what a weird requirement. Re-added them.

 >
 > udpReceiveHandler(): In the "case UDP_EXAMPLE_ORG_BAD" clause, I would
 suggest setting the next expected state (the value of "expected_") at that
 point instead of deferring it to when packet is mangled to keep symmetry
 with the other "case" clauses.  Also, the comment in this clause should
 indicate that the packet will be mangled after it is created to force a
 repeat query over UDP.

 I deferred it to prevent the necessity of another temp var, but adding one
 actually makes more sense (also considering the rest of your comment), so
 i've added a bool mangle_response.

 Changes in c34be1b6a604ffb0a6ef34abfcf9c2fa42451d8c

-- 
Ticket URL: <http://bind10.isc.org/ticket/697#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development