BIND 10 #698: ModuleCCSession object may group_unsubscribe in the closed CC session in being deleted

[BIND 10 Development]

#698: ModuleCCSession object may group_unsubscribe in the closed CC session in
being deleted
-------------------------------------+-------------------------------------
                 Reporter:           |                Owner:  vorner
  naokikambe                         |               Status:  reviewing
                     Type:  defect   |            Milestone:
                 Priority:  major    |  Sprint-20110405
                Component:           |           Resolution:
  message-library                    |            Sensitive:  0
                 Keywords:           |  Add Hours to Ticket:  0
Estimated Number of Hours:  3.0      |          Total Hours:  0
                Billable?:  1        |
                Internal?:  0        |
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => vorner


Comment:

 Thanks for comments.

 Replying to [comment:6 vorner]:
 > So it seems that there's another variable carrying the same information.

 I think it is not definitely same information. According to the original
 class (isc.cc.session.Session), "_socket" variable is a socket object,
 "_closed" variable is boolen, which means whether the session has been
 closed or not.

 However, in unittest_fakesession.py, "_closed" variable is a string
 type(not a socket object), and it is assigned to "closed" string which
 seems to be same meaning as "_closed" variable here. So we will assign
 None instead of "closed" string. Is that OK?
 {{{
          # need to pass along somehow that this function has been called,
 -        self._socket = "closed"
 +        self._socket = None

 }}}

 > And there's another problem. There are no tests for the code.
 unittest_fakesession.py is a test code. I think we don't need test code
 for test code. Is that correct?

-- 
Ticket URL: <http://bind10.isc.org/ticket/698#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development