BIND 10 #609: Check BIND10 responses with real-world traffic
BIND 10 Development
do-not-reply at isc.org
Wed Mar 30 15:54:08 UTC 2011
#609: Check BIND10 responses with real-world traffic
-------------------------------------+-------------------------------------
Reporter: stephen | Owner: hanfeng
Type: task | Status: reviewing
Priority: major | Milestone:
Component: | Sprint-20110405
b10-auth | Resolution:
Keywords: | Sensitive: 0
Estimated Number of Hours: 4.0 | Add Hours to Ticket: 0
Billable?: 1 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => hanfeng
Comment:
Hello
I looked trough it again. I don't remember seeing so many tickets for the
differences found, did anybody create them? (I might have simply
overlooked them, of course).
About the code, it's nicer, but there are still few minor points:
* The {{{_wait_for}}} function, if EINTR happens, it will throw timeout,
if I read correctly.
* Why is the socket in send udp non-blocking? It doesn't matter, you wait
for it to become ready anyway, so it can't block and even if it would, you
don't really check for EAGAIN. Anyway, checking a new port is ready for
write with UDP is useless anyway, it will be just ready (so this might
simplify the code little bit).
* header_cmp: There's bunch of lines like {{{diff['id'] = header1['id']
!= header2['id']}}}. They could be written like:
{{{
for header in list:
diff[header] = header1[header] != header2[header]
}}}
Is it possible to put into a branch in git, so it could be merged? We
might want to run the tests again some time in future. Or is there a
problem with copyright?
Thanks
--
Ticket URL: <http://bind10.isc.org/ticket/609#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list