BIND 10 #889: new bugs from MSVC

[BIND 10 Development]

#889: new bugs from MSVC
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  fdupont                            |                Status:  new
                       Type:         |             Milestone:  New Tasks
  defect                             |            Resolution:
                   Priority:         |             Sensitive:  0
  critical                           |           Sub-Project:  DNS
                  Component:         |  Estimated Difficulty:  0
  Unclassified                       |           Total Hours:  0
                   Keywords:         |
            Defect Severity:  High   |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Description changed by jinmei:

Old description:

> src/lib/cc/data.cc raises a bug with MSVC:
>  - in removeIdentical() (the first one ~ line 851) I get a
>   "map/set iterator not incrementable". Reading the code
>   an iterator  "it"is built from std::map and ++ is called on it even
>   when it can point to end after the remove if it points to the last
>   element...
>
>   BTW the standard way is to have remove() returning the iterator so
>   you can write if () { it = remove(); } else ++it;
>
> src/lib/config/tests (libcfgclient) raises another bug in data.h:
>  - !ListElement remove() (~ line 461) can be called with a bad argument,
>   giving "vector erase iterator outside range". This is triggered by
>   listRemove() (line ~ 67) in fake_session.cc. BTW, I don't understand
>   this function...
>
> I fixed the two bugs to get tests to work without errors. The commit was
> pushed
> on trac826 but please find better fixes!

New description:

 src/lib/cc/data.cc raises a bug with MSVC:

 src/lib/config/tests (libcfgclient) raises another bug in data.h:
  - !ListElement remove() (~ line 461) can be called with a bad argument,
   giving "vector erase iterator outside range". This is triggered by
   listRemove() (line ~ 67) in fake_session.cc. BTW, I don't understand
   this function...

 I believe this one has been fixed in the master branch. (Trac #846)

--

-- 
Ticket URL: <http://bind10.isc.org/ticket/889#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development