BIND 10 #838: "string iterator is not dereferencable" issue

[BIND 10 Development]

#838: "string iterator is not dereferencable" issue
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  ocean
  fdupont                            |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20110517
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by ocean):

 Replying to [comment:9 jinmei]:
 > Replying to [comment:8 ocean]:
 >
 > Could you provide some more context?  Have you successfully reproduced
 > the reported problem?  If so, have you confirmed the change fixed it?
 > The committed change seems to be a simple copy and paste of (part of)
 > what Francis suggested...does that mean you agree that it was the best
 > fix?  Or did you commit it simply because you confirmed it fixed it?
 >
 > Also, what about other issues reported in the ticket?
 Yes I did reproduced this problem on Windows with VS2010. And this can fix
 it.

 But to reproduce this, a lot of code changes need to make otherwise the
 code cannot be compiled, all the changes are scattered in several related
 tickes  #827 #829 #831 #832  #836 #837 #839 #858

 For this ticket, the current fix should be enough. Another concern is the
 isspace() problem, because this can only reproduced in DEBUG version. But
 it seems add the {{{(int)xxx & 0xFF}}} will not do any harm, so I will add
 it too.

 For other related tickets, I'm not sure whether we should fix it one by
 one or create another ticket to put windows related code changes into the
 trunk. It seems that Shane does not hope to waste too much time on Windows
 platform.:)

-- 
Ticket URL: <http://bind10.isc.org/ticket/838#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development