BIND 10 #745: Conversion of nsas library to use the new logging interface

[BIND 10 Development]

#745: Conversion of nsas library to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  minor  |            Resolution:
                  Component:         |             Sensitive:  0
  resolver                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  logging                            |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 Replying to [comment:7 stephen]:
 > a. You did a build before doing a "make distcheck".
 > b. The Makefile.am in this ticket was incomplete - it did not include
 the created files on the CLEANFILES line. (In fact it also missed a couple
 of other lines as well - an update to this branch corrects that.)

 Ah, I see. And I saw this branch fail for me as well now.

 > As to #744: Automake has to copy the generated files when creating the
 distribution because they are listed in the <library>_SOURCES variable.
 As they don't exist, it applies the dependency rule and tries to create
 them from the message file using the message compiler. Unfortunately at
 this stage the message compiler does not exist, hence the error.  The
 solution is not to distribute the generated files, which can be done by
 putting them in the noinst_<library>_SOURCES variable instead.

 Hmm, noinst sounds to me like they shouldn't be installed by make install.
 Shouldn't that be some kind of nodist_?

 Anyway, my failure wasn't at that point at all. It was after unpacking the
 package, when compiling. At first it was that it didn't find the file,
 then after including the full path, the message compiler complained it
 can't output the result because of permissions ‒ it wanted to output to
 the srcdir.

 > What puzzles me though is why updating the message compiler fixed it in
 ticket #744 - my guess is that this was coincidental.  (More on the
 message compiler in the review of that ticket.)

 That's the second part ‒ I need it to read from srcdir and output to
 builddir. That seems to work correctly. But yes, I'll include the makefile
 fixes from here to #744 as well.

 Anyway, I believe this branch needs the compiler fix as well. It fails the
 same way now:
 {{{
 make[5]: Entering directory
 `/home/vorner/work/bind10/bind10-devel-20110322/_build/src/lib/nsas'
 ../../../src/lib/log/compiler/message ../../../../src/lib/nsas/nsasdef.mes
 ../../../src/lib/log/compiler/message ../../../../src/lib/nsas/nsasdef.mes
 OPNMSGOUT, unable to open ../../../../src/lib/nsas/nsasdef.h for output:
 Permission denied
 make[5]: *** [nsasdef.cc] Error 1
 make[5]: *** Waiting for unfinished jobs....
 OPNMSGOUT, unable to open ../../../../src/lib/nsas/nsasdef.h for output:
 Permission denied
 make[5]: Leaving directory
 `/home/vorner/work/bind10/bind10-devel-20110322/_build/src/lib/nsas'
 }}}

 But I think that, as you suggested in email, we wait here for #901 and
 that one already includes the message compiler fix as well.

-- 
Ticket URL: <https://bind10.isc.org/ticket/745#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development