BIND 10 #901: Alter logging interface to use positional formatting for message arguments

[BIND 10 Development]

#901: Alter logging interface to use positional formatting for message arguments
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 Just a few minor points that occurred to me now I've seen the updated
 code.

 '''src/lib/log/log_formatter.h'''[[BR]]
 As the code no longer creates a new Formatter object, there is no reason
 for nextPlaceholder to be a constructor argument; nextPlaceholder_ could
 be set to a known value in the constructor.

 Assuming nextPlaceholder_ is removed, if logger were to be passed as a
 pointer - instead of a reference - defaults of NULL could be assigned to
 all arguments and only one constructor would be needed.

 If logger were passed as a pointer, there would be no need for active_;
 the logger_ variable could serve as a check as to whether the logger is
 active or not.

-- 
Ticket URL: <http://bind10.isc.org/ticket/901#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development