BIND 10 #598: Resolver DO bit, forwarder pass DO bit

[BIND 10 Development]

#598: Resolver DO bit, forwarder pass DO bit
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  vorner
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20110517
                  Component:         |            Resolution:
  resolver                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  40.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by zhanglikun):

 * owner:  zhanglikun => vorner


Comment:

 Replying to [comment:22 vorner]:
 > Hello
 >
 > It took me a little while to find out what was the original problem with
 the test. Do I get it right it created a forwarding query and then asked
 it to be resolved instead of forwarded?
 >

 That test case was designed for old code, which RunningQuery support
 forwarding query(by seting a address to upstream_), but now forward logic
 has been moved from RunningQuery to FowardQuery. so you have to forward if
 the parameter "upstream_" of RecursiveQuery is not None.


 > Anyway, the comments around and inside of the test are clearly wrong. I
 must admit they were wrong even before that. But could you fix them to
 describe what it does? And then just merge it, I don't need to see the
 comments again.
 >

 OK, I will do it when I merge the ticket tommorrow(let's wish it's a easy
 work)

 > And, one more thing. I guess if we do something the test did (eg. create
 a query for forwarding and then asks it to resolve it or vice versa), it
 should throw an exception. Could you create a ticket for it? I think this
 branch is old enough and wants to get into master.

 I'm not sure it's a good idea or not, maybe later we need to move the
 Forward query from RecursiveQuery. What's your opinion? As shane's
 opinion, maybe we will create a single process for forwarder later.

 > Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/598#comment:23>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development