BIND 10 #815: TSIG: update XFRIN to use TSIG

[BIND 10 Development]

#815: TSIG: update XFRIN to use TSIG
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  zzchen_pku
  stephen                            |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  minor  |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5.0
Feature Depending on Ticket:  tsig   |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => zzchen_pku


Comment:

 Replying to [comment:9 zzchen_pku]:
 > > kind of the same thing on line 137, although here i don't really get
 why the if is there in the first place (with the default for the second
 argument of msg.to_wire() set to None, you could just pass the _tsig_ctx
 whether it's None or not, and not do a check here), or is this a python
 wrapper limitation?
 > Right, python wrapper doesn't accept 'None' parameter in this case.

 ok. I don't know from the top of my head how to add that, but i think we
 should (and then remove the if here), but for now I think this is good
 enough. Could you add a small comment why the if is there with a TODO
 here?

 > >
 > > xfrin_test.py:
 > >
 > > are we sure that strip_mutable_tsig_data will not fail with its direct
 array addressing? Related question: should we provide the functionality to
 'tweak current time' to do this?
 > Yes, it's another way to do this, but I have no idea how to 'tweak
 current time'?

 me neither :) Let's leave it for now.

 > > And I'm not sure if it's possible right now, since not everything is
 done yet, but we should probably also test some actual tsig use and
 failure scenarios and see if xfrin daemon fails gracefully with bad tsigs
 > Added some unittest.  I'd add more test cases after python wrapper has
 been completed, or do you have any suggestions which scenarios should be
 considered now?

 No suggestions for now, perhaps we can bring this up at the call, and the
 adding of the tests can be part of the final wrapup of all tsig tasks.

 With that one added TODO-comment, I think this is ready for merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/815#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development