BIND 10 #743: Conversion of config library to use the new logging interface
BIND 10 Development
do-not-reply at isc.org
Wed May 11 15:06:17 UTC 2011
#743: Conversion of config library to use the new logging interface
-------------------------------------+-------------------------------------
Reporter: | Owner: jelte
stephen | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20110517
Priority: minor | Resolution:
Component: | Sensitive: 0
configuration | Sub-Project: DNS
Keywords: | Estimated Difficulty: 5.0
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
logging |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => jelte
Comment:
Reviewed commit f5278f2ac4becb33b93dc4c2fa7e6558a7daad8f
'''src/lib/config/config_log.h'''[[BR]]
Should get rid of unused debug-level definitions (which are not relevant
to this module).
Comment is wrong - isc::config::'''config_'''logger is the CONFIG logger.
'''src/lib/config/configdef.mes'''[[BR]]
Suggest that the message text start with a lower-case character (unless
something that should be in capital letters such as the type of a resource
record). The reason is that (the current) message formatting is
{{{
MESSAGE_ID, message text
}}}
...and a lower-case letter after the comma follows the rules of English.
(Does not apply to the JSON_PARSE error, where the first word is JSON
which should be in upper-case.)
!ChangeLog entry is fine.
Another review is not useful, please merge when you've made the changes.
--
Ticket URL: <http://bind10.isc.org/ticket/743#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list