BIND 10 #889: new bugs from MSVC

[BIND 10 Development]

#889: new bugs from MSVC
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:
  fdupont                            |                Status:  closed
                       Type:         |             Milestone:
  defect                             |            Resolution:  fixed
                   Priority:         |             Sensitive:  0
  critical                           |           Sub-Project:  DNS
                  Component:         |  Estimated Difficulty:  0.0
  Unclassified                       |           Total Hours:  0
                   Keywords:         |
            Defect Severity:         |
  Medium                             |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by fdupont):

 Please reopen it: there were two bugs, only the second was fixed.
 With the correct description and only the first bug:

 src/lib/cc/data.cc raises a bug with MSVC:
  - in removeIdentical() (the first one ~ line 851) I get a "map/set
 iterator not incrementable". Reading the code an iterator "it" is built
 from std::map and ++ is called on it even when it can point to end after
 the remove if it points to the last element...

 BTW the standard way is to have remove() returning the iterator so you can
 write
 if () { it = remove(); } else ++it;

-- 
Ticket URL: <http://bind10.isc.org/ticket/889#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development