BIND 10 #542: catching exceptions in run_unittests

[BIND 10 Development]

#542: catching exceptions in run_unittests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  minor  |            Resolution:
                  Component:  build  |             Sensitive:  0
  system                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:7 stephen]:

 I'm willing to review this, but it failed to compile with clang++
 on my MacOS X (10.6.7) in tests/tools/badpacket:

 {{{
 /bin/sh ../../../../libtool --tag=CXX   --mode=link clang++ -Wall -Wextra
 -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -Werror -fPIC -g
 -O2  -L/opt/local/lib -Wl,--as-needed
 ../../../../src/lib/exceptions/libexceptions.la
 ../../../../src/lib/util/libutil.la -R/opt/local/lib       -o
 run_unittests run_unittests-run_unittests.o run_unittests-
 command_options_unittest.o run_unittests-option_info_unittest.o
 run_unittests-header_flags_unittest.o run_unittests-command_options.o
 run_unittests-option_info.o -lgtest -D_THREAD_SAFE
 ../../../../src/lib/util/unittests/libutil_unittests.la
 libtool: link: clang++ -Wall -Wextra -Wwrite-strings -Woverloaded-virtual
 -Wno-sign-compare -Werror -fPIC -g -O2 -Wl,--as-needed -o
 .libs/run_unittests run_unittests-run_unittests.o run_unittests-
 command_options_unittest.o run_unittests-option_info_unittest.o
 run_unittests-header_flags_unittest.o run_unittests-command_options.o
 run_unittests-option_info.o -D_THREAD_SAFE -Wl,-bind_at_load
 -L/opt/local/lib ../../../../src/lib/exceptions/.libs/libexceptions.dylib
 ../../../../src/lib/util/.libs/libutil.dylib /opt/local/lib/libgtest.dylib
 ../../../../src/lib/util/unittests/.libs/libutil_unittests.dylib
 /Users/jinmei/src/isc/git/bind10-542/src/lib/util/.libs/libutil.dylib
 /Users/jinmei/src/isc/git/bind10-542/src/lib/util/io/.libs/libutil_io.dylib
 /Users/jinmei/src/isc/git/bind10-542/src/lib/exceptions/.libs/libexceptions.dylib
 ld: unknown option: --as-needed
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 }}}

 I've seen this error with clang++ on a FreeBSD machine before.  In
 that case a long test case (somehow) triggered it, so as a workaround
 we divided it into two smaller tests (it's
 CCSessionTest.checkCommand[,2] btw).

 Assuming you use MacOS X, I suggest you try to reproduce it and fix it
 first.

-- 
Ticket URL: <http://bind10.isc.org/ticket/542#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development