BIND 10 #915: TSIG: (really) complete python library update

[BIND 10 Development]

#915: TSIG: (really) complete python library update
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110517
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  DNSPacket API                      |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  2.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:6 jelte]:

 Thanks for review!
 >
 > general:

 > didn't compile :/ I had to move a few headers up (see attached diff for
 > what made it work for me), I did notice that in a few source files
 > Python.h is explicitely included before anything else, that is also a
 > possibility (would need to be added to the two files touched in my diff,
 > where i just moved pydnspp_common.h to be the first, which also works
 > becaurse the first thing that header does is include Python.h)

 Ah, okay.  I already noticed missing Python.h at the head of file
 caused build failure on some systems, but in this branch it's not
 fully addressed.  I've added it to the two files you modified in your
 diff.  If possible can you confirm it compiles for you?


 > except for this i think all my comments can be defered to the cleanup
 stage, but i wanted to mention them anyway:

 Okay, these look good points, but as you mention I'd carry them over
 to #932.

 I fixed one very trivial (and not actually related to this ticket)
 point:

 > and one completely unrelated comment/annoyance :)
 > the TSIG construction exception misses a space in tsig_250.cc:
 >     if (iss.bad() || iss.fail()) {
 >         isc_throw(InvalidRdataText, "Invalid TSIG text: parse error" <<
 >                   full_input);

-- 
Ticket URL: <http://bind10.isc.org/ticket/915#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development