BIND 10 #946: xfrin fails to do retransfer with TSIG

[BIND 10 Development]

#946: xfrin fails to do retransfer with TSIG
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  new
                       Type:         |             Milestone:
  defect                             |  Sprint-20110531
                   Priority:  major  |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  High   |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Branch trac946 is ready for review.

 The first commit is not directly relevant to fix the bug, but will help
 when the bug actually occurred (and it's generally advisable to catch
 possible C++ exceptions gracefully anyway).

 The main fix is in xfrin.py.in, which should be mostly trivial.

 See the new test test_do_soacheck_and_xfrin_with_tsig for what was
 wrong and what is actually expected.

 Other tests were also modified due to the change of how xfrin manages
 tsig contexts internally.  They are a bit complicated due to the
 introduction of a lambda expression (as a hook for faked context),
 but their behavior was essentially the same.

 I don't plan to add a changelog entry for this because this bug has
 been in master for a very short period and  in mostly invisible to
 public.

-- 
Ticket URL: <http://bind10.isc.org/ticket/946#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development