BIND 10 #542: catching exceptions in run_unittests

BIND 10 Development do-not-reply at isc.org
Mon May 23 10:47:31 UTC 2011


#542: catching exceptions in run_unittests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110531
                   Priority:  minor  |            Resolution:
                  Component:  build  |             Sensitive:  0
  system                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 > maybe a matter of taste, but it seems we can now merge tests and
 io_tests. wouldn't it be simpler?
 Yes it would.  Done.

 > I'd like to enable it by default for clang++.
 Done.  I've chosen a simpler solution than making it a configure option,
 simply choosing the default as to whether the compiler defines the symbol
 !__clang!__.  (The reason being that the test will terminate regardless,
 so whether or not the unexpected exception is caught is only really of
 interest to someone debugging a test - who could be expected to set
 B10TEST_CATCH_EXCEPTION appropriately.)

 > One more thing: I'd also suggest introducing a wrapper for
 EXPECT_NO_THROW as mentioned in:
 https://lists.isc.org/pipermail/bind10-dev/2011-January/001891.html but
 the amount of diff would be even bigger, so we should probably defer it to
 a separate ticket (I'm completely fine with that).
 I've created ticket #958 for it

 Suggested !ChangeLog entry:
 {{{
 XXX.    [func]          stephen
         In unit tests, allow the choice of whether unhandled exceptions
 are
         caught in the unit test program (and details printed) or allowed
 to
         propagate to the default exception handler.  See the bind10-dev
 thread
 https://lists.isc.org/pipermail/bind10-dev/2011-January/001867.html
         for more details.
         (Trac #542, git xxxx)
 }}}

-- 
Ticket URL: <https://bind10.isc.org/ticket/542#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list