BIND 10 #951: SHA224 unsupported algorithm unit test failure

[BIND 10 Development]

#951: SHA224 unsupported algorithm unit test failure
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:  UnAssigned
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:  New Tasks
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  Unclassified                       |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => UnAssigned
 * status:  assigned => reviewing


Comment:

 I made two commits, the first one is a workaround for the compilation
 problem.

 I'm not sure that is an acceptable solution though; the problem is that
 GTEST_LDFLAGS is added, which in itself should not be bad, but on this
 particular system the path in there also contains the wrong botan. libtool
 or ld does match this and then links to it, instead of the right one
 (which is also in the existing path settings, but later). So the
 workaround adds BOTAN_LDFLAGS to the relevant makefiles. I also added a
 test here to trigger this problem in libdns++ tests.

 The second patch is only slightly related; there were more disabled tests
 (three truncated sigs tests), which were disabled because they failed.
 Turns out they failed because of an hardcoded return false in verify()
 (which did have nice documentation as to why, btw). Removed that temporary
 code, and enabled those tests.

 If we decide not to merge the first commit, I request we cherry-pick the
 second one (which is quite simple)

-- 
Ticket URL: <http://bind10.isc.org/ticket/951#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development