BIND 10 #954: avoid using macro in crypto_unittests

[BIND 10 Development]

#954: avoid using macro in crypto_unittests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:  New Tasks
  defect                             |            Resolution:
                   Priority:  major  |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  Unclassified                       |  Estimated Difficulty:  0.0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 The patch does not apply cleanly to master (anymore?), but was quite easy
 to reproduce (i could upload a new one if you want). In order for the
 tests not to fail though, i had to remove a temporary bit of code from
 HMAC::verify() (the same return false i had to remove for #951).

 Code looks much better, however, it is still a bit more brittle than i'd
 like to see; so i have one more suggestion the for-loop at the end of
 doRFC4231Tests() should have its conditional check on the lengths of all
 three vectors (or there should be a test just before it to check they are
 of equal size), otherwise one if someone was to remove one of the
 elements, it would segfault.

 i only saw this was not for this sprint after i was half done with it,
 sorry for that, i'm reassigning it back to you anyway (you may ignore if
 you want to or we could cheat)

-- 
Ticket URL: <http://bind10.isc.org/ticket/954#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development