BIND 10 #746: Configuration of resolver library to use the new logging interface

BIND 10 Development do-not-reply at isc.org
Wed May 25 10:00:04 UTC 2011


#746: Configuration of resolver library to use the new logging interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  closed
                       Type:         |             Milestone:
  enhancement                        |  Sprint-20110531
                   Priority:  minor  |            Resolution:  complete
                  Component:         |             Sensitive:  0
  resolver                           |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  2.0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * status:  reviewing => closed
 * resolution:   => complete


Comment:

 > These were only editorial, and I had one suggestion for content; the RTT
 output message should probably include the unit.
 Done.

 > General question: should we consider having a standard naming convention
 for for instance DEBUG, or is something like that already included in the
 final output? (i see a lot of messages where the description begins with
 'debug message')
 I don't think so - I think we need to separate the message from its
 severity.

 A lot of message descriptions begin with the same text because they are
 not intended to be read sequentially.  I see it more that if a message
 appears, the user will go to the (to be created) messages manual and look
 it up; for this reason the description needs to contain all the
 information needed for it to be understood in isolation.

 > Changes look ok.
 Thanks - merged to master in commit
 14a1dcf8c6d299b7b7d91b27c4bd73b06e1fd61d.

 > I would strongly suggest we change the toText() implementation of
 Question (and probably some related ones as well) to not include the
 newline.  IMO one-string/line output should not include it (this is a good
 example of why). But since that requires a few more changes than just
 removing the newline itself, i think we should create a separate ticket
 for that.
 Strongly agree, and I've created ticket #962 for it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/746#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list