BIND 10 #931: Implement signing part in b10-auth

BIND 10 Development do-not-reply at isc.org
Wed May 25 16:12:08 UTC 2011


#931: Implement signing part in b10-auth
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20110531
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:  tsig   |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:20 vorner]:

 One quick point:

 > > '''server_common/keyring.cc'''
 > > - do we have a test for the change to keyring.cc?
 >
 > Which change? The only change that happened from last time was adding of
 the parameter for the remote config from master and that one is implicitly
 tested from the usual tests. Actually, it was the tests which brought
 attention to the need to adding the false to the call.

 Sorry for not being clear.  I meant the added check for list == NULL
 in updateKeyring():

 {{{
 void
 updateKeyring(const std::string&, ConstElementPtr data) {
 ...
     for (size_t i(0); list && i < list->size(); ++ i) {

 }}}
 (in 67d9442a23eb4fab4dff3f4d1ab142948e21e880)

 I provided this patch without a test at that time.

-- 
Ticket URL: <http://bind10.isc.org/ticket/931#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list