BIND 10 #899: Implement logging using Log4cplus
BIND 10 Development
do-not-reply at isc.org
Thu May 26 08:53:19 UTC 2011
#899: Implement logging using Log4cplus
-------------------------------------+-------------------------------------
Reporter: | Owner: stephen
stephen | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110531
Component: | Resolution:
logging | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0.0
Feature Depending on Ticket: | Total Hours: 0
logging |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => stephen
Comment:
Hello
Replying to [comment:9 stephen]:
> > Isn't a class with only static methods a little bit misleading? Such
class is more like namespace, isn't it? (Not that it would produce
different code, in the end)
> Possibly, but I wanted to group the methods together (the init() call
relates to two of those methods) and indicate that they are
implementation-specific functions. Putting them in the general isc::log
namespace loses that grouping, but I didn't want to create a new namespace
under it. A class name ending in Impl provides the grouping and conveys
the information that they are implementation-specific (so are related to
other xxxImpl classes).
OK. Just a matter of preference I guess.
> > specify exact directory of log4cplus library and headers ‒ this
message looks strange to me. Is it possible to specify inexact directory?
And it looks like they should live in one directory, but one is in lib,
one in include, I really wondered which one of them you mean for a short
while. Wouldn't „installation prefix of log4cplus“ be better?
> configure.ac also includes the messages "specify exact directory of
Botan library" and "specify exact directory for Boost headers", so I guess
this one is consistent.
Ah, OK. I've never seen them, because I have these libraries from portage.
Log4cplus wasn't there, so it's installed in different location.
So, I guess this can be merged. At last, it does build here, so hopefully
not many breakages will happen.
--
Ticket URL: <http://bind10.isc.org/ticket/899#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list