BIND 10 #1287: ZoneIterator will need an internal finder

BIND 10 Development do-not-reply at isc.org
Wed Nov 2 16:42:41 UTC 2011


#1287: ZoneIterator will need an internal finder
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 Just some minor things:
 * This is probably rest of the one commit of mine, but I guess it's no
 longer needed (in database.cc):
 {{{#!c++
 +
 +    virtual ZoneFinder& getFinder() {
 +        isc_throw(NotImplemented, "Not implemented");
 +    }
 }}}
 * I guess this is never called multiple times? Otherwise the copy will be
 done to itself. Would that be OK?
 {{{#!c++
 virtual void startTransaction() {
         // Currently we only use this transaction for simple read-only
         // operations.  So we just make a local copy of the data (we don't
         // care about what happens after commit() or rollback()).
         readonly_records_copy_ = *readonly_records_;
         readonly_records_ = &readonly_records_copy_;
 }
 }}}
 * A typo: `updateAfterDelteIterator`

-- 
Ticket URL: <http://bind10.isc.org/ticket/1287#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list