BIND 10 #213: Change hard-coded process startups to configuration-driven
BIND 10 Development
do-not-reply at isc.org
Thu Nov 3 17:28:17 UTC 2011
#213: Change hard-coded process startups to configuration-driven
-------------------------------------+-------------------------------------
Reporter: shane | Owner: jinmei
Type: | Status: reviewing
enhancement | Milestone:
Priority: major | Sprint-20111108
Component: Boss | Resolution:
of BIND | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 9
Feature Depending on Ticket: | Total Hours:
Add Hours to Ticket: |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:46 vorner]:
> > Not fully looked into it yet, but the test failed:
> >
> > {{{
> > ERROR: test_component_attributes (__main__.ComponentTests)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File
"/Users/jinmei/src/isc/git/bind10-213inc/src/lib/python/isc/bind10/tests/component_test.py",
line 469, in test_component_attributes
> > self.assertIsInstance(component._procinfo, TestProcInfo)
> > AttributeError: 'ComponentTests' object has no attribute
'assertIsInstance'
> > }}}
>
> It seems your version of unittest lacks the assertIsInstance check. Does
the workaround work for you?
Ah, yes. According to http://docs.python.org/py3k/library/unittest.html
assertIsInstance is new in Python 3.2 (I'm (normally) using 3.1).
As for the test itself: it looks good. I'll test some other cases:
- this code path
{{{
else:
# TODO Handle params, etc
procinfo = self._boss.start_simple(self._process)
}}}
- stop()
- kill()
--
Ticket URL: <http://bind10.isc.org/ticket/213#comment:47>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list