BIND 10 #1365: Restarts in #213

[BIND 10 Development]

#1365: Restarts in #213
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  Boss   |            Resolution:
  of BIND                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:5 vorner]:

 > > - maybe rename BoB.processes to BoB.components?
 >
 > I added comment about that, I believe processes is better, since there
 isn't one-to-one mapping between components and processes.

 I see, but then doesn't this contradict the idea?
 {{{
                 component = self.processes.pop(pid)
 }}}
 or
 {{{
             components_to_stop = list(self.processes.values())
             for component in components_to_stop:
 }}}

 Actually, these code fragments made me make this comment.

 > > - test_show_processes_started: I'm not sure if this replacement is
 > >   okay.  [...]
 >
 > Actually, this tests the method that lists the currently running
 processes, when you send the Boss show_processes command. It didn't test
 the right processes are started, the start_all_processes was used to only
 fill in some processes to be tested. Actually, this way it is closer to
 the idea of unit tests, testing only the one thing, and it is the function
 providing the processes. It is more or less the same as the above test,
 but checks it works even when there are some tests (so the format can be
 checked).

 Okay, but in that case I'd rename the test to, e.g. just
 test_show_processes(), and the original test_show_processes() to
 test_show_processes_empty().

 Other changes look okay.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1365#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development