BIND 10 #1228: V4 packet library - option processing

[BIND 10 Development]

#1228: V4 packet library - option processing
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  tomek
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:  Sprint-
                   Priority:  major  |  DHCP-20111109
                  Component:  dhcp   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:         |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tomek


Comment:

 > BTW do we want space after unary operator '!' Should it be
 > {{{
 >    if (! data_.empty())
 >
 > or
 >
 >   if (!data_.empty())
 > }}}
 I think the latter for unary operators.  It's not in the
 [wiki:CodingGuidelines BIND 10 Coding Guidelines] but the issue of spaces
 between operators is covered in the [wiki:BIND9CodingGuidelines BIND 9
 Coding Guidelines].

 > ''(EXPECT_EQ v EXPECT_TRUE)''
 > Fixed. I'm wondering why this does compile for me. I really need to
 switch to a different version of gcc/g++. I'm currently using g++ 4.5.2
 (the default in Ubuntu 11.04). It seems very liberal in what it accepts.
 This caused problems more than once...
 My guess is that the library that comes with g++ 4.5 has an operator<<()
 defined for outputting a vector.

 All OK, please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1228#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development