BIND 10 #1298: don't do xfrin upon notify when address is unknown

[BIND 10 Development]

#1298: don't do xfrin upon notify when address is unknown
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 jelte]:

 > [bug] jelte
 > b10-xfrin would previously initiate incoming transfers upon receiving
 > NOTIFY packets from any address (if the zone was known to b10-xfrin).

 - s/packets/messages/
 - I'd say: "...was known to b10-xfrin, and using the configured master
 address)".

 > It now only starts a transfer if the source address from the NOTIFY
 > packet matches the configured master address and port. This was really

 s/packet/message/

 > already fixed in release bind10-devel-20111014, but there were some
 > deferred cleanups to add.

 > ack, only comparing family, addr and port now. BTW this seems more
 > like a big hint that we are using bad datastructures here, but anyway.

 Perhaps.  At least we should have a consistent style for comparing
 addresses in this type of context.  But that will be beyond the scope
 of this ticket.

 Other comments:

 - I've made a couple of fixes and pushed them.  Both minor, but the
   first one was necessary to compile with clang.
 - format_addrinfo: it doesn't check invalid combination of family
   address like this: `format_addrinfo((socket.AF_INET, None, ("::1",
 54)))`
   (not sure if we want to catch them in this function though)
 - test_format_addrinfo: mostly a matter of taste in this context, but
   I'd use 2001:db8::XX for testing instead of ::1 or ::2 (especially
   the latter)
 - test_format_addrinfo: I think it's better to use more typical value
   for addr[1] (i.e. 'sockettype'), so instead of
 {{{
         self.assertEqual("192.0.2.1:53",
                          format_addrinfo((socket.AF_INET, None,
                                           ("192.0.2.1", 53))))
 }}}
   do this:
 {{{
         self.assertEqual("192.0.2.1:53",
                          format_addrinfo((socket.AF_INET,
 socket.SOCK_STREAM,
                                           ("192.0.2.1", 53))))
 }}}
  (it may still make sense to use a bogus value, too, to see if it's
   really ignored)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1298#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development