BIND 10 #1298: don't do xfrin upon notify when address is unknown

BIND 10 Development do-not-reply at isc.org
Tue Nov 8 16:32:21 UTC 2011


#1298: don't do xfrin upon notify when address is unknown
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:         |            Resolution:
  Unclassified                       |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:14 jelte]:

 > > - format_addrinfo: it doesn't check invalid combination of family
 > >   address like this: `format_addrinfo((socket.AF_INET, None, ("::1",
 54)))`
 > >   (not sure if we want to catch them in this function though)
 >
 > not sure either. It would feel a bit too much to me (what would we do?
 > raise an error? if so, why? Would only be something more the caller
 > would have to take into account. And if we add code that recognizes
 > valid addresses for families, we wouldn't even need the address family
 > in the argument in the first place (except then perhaps for said
 > checking). So for now let's keep it bogus-in-bogus-out. Perhaps we can
 > reconsider in #1379.

 Works for me.

 Other changes are okay.  I think this is ready for merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1298#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list