BIND 10 #1381: Dropping root on #213
BIND 10 Development
do-not-reply at isc.org
Tue Nov 8 18:35:37 UTC 2011
#1381: Dropping root on #213
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
vorner | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20111122
Component: Boss | Resolution:
of BIND | Sensitive: 0
Keywords: | Sub-Project: Core
Defect Severity: N/A | Estimated Difficulty: 0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
I happened to notice an editorial error in a docstring (not related to
this branch) and fixed it.
The code basically looks okay, but if you haven't please make sure if
-u really works as expected on an installed system (this is something
we don't test (at it's mostly impossible) through our unit and system
tests).
Some comments on the code:
'''special_component.py'''
- SetUID: s/forefull/forcefull/ here:
{{{
def kill(self, forefull=False): pass
}}}
- why is this a TODO? It seems to be a quite trivial addition:
{{{
if self.uid is not None:
# TODO: log
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/1381#comment:3>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list