BIND 10 #1288: Update XFROUT to use new interface
BIND 10 Development
do-not-reply at isc.org
Tue Nov 8 23:08:24 UTC 2011
#1288: Update XFROUT to use new interface
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: accepted
Type: task | Milestone:
Priority: major | Sprint-20111122
Component: | Resolution:
xfrout | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
trac1288 is ready for review.
The branch resulted in a bit bigger than I expected, partly because
I didn't realize I would need to updte notify_out, too. Here are some
hints for the reviewer that hopefully mitigates the review load:
- changes to xfrout and notify_out are completely independent. So, if
the entire branch is deemed to be too big, we can separate these
into separate (conceptual or real) sub tasks and review them
separately.
- commit 7a59033 is also independent from others, but is necessary for
the change to work in an installed environment.
- main changes for the topic of this task are marked in the commit
logs as "switch to new API'. Others are basically related cleanups
or small bug fixes piggy-backed on this ticket.
- commit ca42fb6 is a bug fix, and it's not directly specific to this
branch (this problem should exist in the current implementation,
too), but using a generic datasource API may increase the
possibility of getting exceptions unexpectedly, which will increase
the possibility of this bug. So I decided to fix it in this branch.
Again, if the branch seems to be too big, we can defer this part to
a separate branch or task.
- commit f01fb1d is an improvement on top of the changes. I believe
this is useful and thought it was a good opportunity to make it
happen, but once again this can be deferred.
--
Ticket URL: <http://bind10.isc.org/ticket/1288#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list