BIND 10 #1378: Configuration of #213

BIND 10 Development do-not-reply at isc.org
Wed Nov 9 19:46:56 UTC 2011


#1378: Configuration of #213
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:  Boss   |            Resolution:
  of BIND                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  Core
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:7 vorner]:

 > > - TestBossComponents: is there anything that has changed from the
 > >   original trac213 tests?  (I'm asking whether I need to review this
 > >   again)
 >
 > I copy-pasted it from the original version. I'm not 100% sure if I
 needed to update any variable names which might have changed in between,
 but they are the same otherwise.

 I noiced one thing (not actually specific to this test): in another branch
 we renambed BoB.processes to BoB.components.  So we should eventually be
 consistent with the naming in the tests (for MockBob, and as a result
 in TestBossComponents).

 In my first review I only made one comment for this test, which seemed
 to be addressed.  I've not looked into it any closer, but from a quick
 glance I've not found anything obvious wrong except for
 s/processes/components/.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1378#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list