BIND 10 #1288: Update XFROUT to use new interface
BIND 10 Development
do-not-reply at isc.org
Mon Nov 14 16:46:04 UTC 2011
#1288: Update XFROUT to use new interface
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20111122
Component: | Resolution:
xfrout | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Replying to [comment:15 jinmei]:
> Okay, I did it, but to make it workable I needed to merge this branch
> with master, which caused a lot of conflicts. One of them is non
trivial
> (the conflict resolution change in bind10_src.py.in at commit a6fd03e),
> so please carefully check that.
Hmm, I did expect it to be much easier. But taking most of it were the
conflicts, it would have need to be done anyway.
Regarding the change, I've few notes:
* You added the class for XfrOut, but not to the dict at the bottom of
the special_component.py. This way the installed program can't be started.
* As xfrout shouldn't be started by start_simple any more, it should be
removed from the test version of start_simple.
* The name 'Xfrout' is inconsistent with the rest in the bob.spec (all
others are all lover case).
* More to the workaround itself, we now have two with the same
workaround, with more to expect, probably? Would it be better to just pass
the environment variable to anything started? Other things shouldn't be
hurt by it anyway and it would remove two specials, making it easier for
the user. Or, should we try talking about it tomorrow at the call?
> > Should I try to look what happens or can you reproduce or guess?
>
> Hmm, I couldn't reproduce it on my personal machine or on git.bind10
> (a Linux box). So I have no clue. Could you try to get more details
> about it? For example, printing debug logs may help.
Neither I can any longer. So it probably was some kind of false alarm
(memory corruption or inconsistency of gcc version between the python
itself and the modules).
> Do you mean like this?
> {{{
> try:
> self.dns_xfrout_start(self._sock_fd, self._request_data,
quota_ok)
> except Exception as e:
> logger.error(XFROUT_HANDLE_QUERY_ERROR, ex)
> finally:
> # Release any critical resources
> if quota_ok:
> self._server.decrease_transfers_counter()
> self._close_socket()
> }}}
>
> I didn't do this because the `finally` part isn't executed if
> logger.error raises an exception.
I see.
Anyway, normal tests pass, but now a distcheck fails:
{{{
======================================================================
ERROR: test_send_notify_message_udp_ipv4 (__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20111021/_build/../src/lib/python/isc/notify/tests/notify_out_test.py",
line 251, in test_send_notify_message_udp_ipv4
('192.0.2.1', 53))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 460, in _send_notify_message_udp
RRClass(zone_notify_info.zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 490, in _create_notify_message
zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 501, in _get_zone_soa
datasrc_config).find_zone(zone_name)
isc.datasrc.Error: Failed to create DataSourceClient of type
sqlite3:sqlite3_ds.so: cannot open shared object file: No such file or
directory
======================================================================
ERROR: test_send_notify_message_udp_ipv6 (__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20111021/_build/../src/lib/python/isc/notify/tests/notify_out_test.py",
line 258, in test_send_notify_message_udp_ipv6
('2001:db8::53', 53))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 460, in _send_notify_message_udp
RRClass(zone_notify_info.zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 490, in _create_notify_message
zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 501, in _get_zone_soa
datasrc_config).find_zone(zone_name)
isc.datasrc.Error: Failed to create DataSourceClient of type
sqlite3:sqlite3_ds.so: cannot open shared object file: No such file or
directory
======================================================================
ERROR: test_send_notify_message_with_bogus_address
(__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20111021/_build/../src/lib/python/isc/notify/tests/notify_out_test.py",
line 270, in test_send_notify_message_with_bogus_address
('invalid', 53))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 460, in _send_notify_message_udp
RRClass(zone_notify_info.zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 490, in _create_notify_message
zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 501, in _get_zone_soa
datasrc_config).find_zone(zone_name)
isc.datasrc.Error: Failed to create DataSourceClient of type
sqlite3:sqlite3_ds.so: cannot open shared object file: No such file or
directory
======================================================================
ERROR: test_wait_for_notify_reply (__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20111021/_build/../src/lib/python/isc/notify/tests/notify_out_test.py",
line 165, in test_wait_for_notify_reply
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 434, in _zone_notify_handler
self._send_notify_message_udp(zone_notify_info, tgt)
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 460, in _send_notify_message_udp
RRClass(zone_notify_info.zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 490, in _create_notify_message
zone_class))
File
"/home/vorner/work/bind10/bind10-devel-20111021/src/lib/python/isc/notify/notify_out.py",
line 501, in _get_zone_soa
datasrc_config).find_zone(zone_name)
isc.datasrc.Error: Failed to create DataSourceClient of type
sqlite3:sqlite3_ds.so: cannot open shared object file: No such file or
directory
======================================================================
FAIL: test_get_notify_slaves_from_ns (__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20111021/_build/../src/lib/python/isc/notify/tests/notify_out_test.py",
line 311, in test_get_notify_slaves_from_ns
self.assertEqual(6, len(records))
AssertionError: 6 != 0
======================================================================
FAIL: test_init_notify_out (__main__.TestNotifyOut)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/vorner/work/bind10/bind10-devel-20111021/_build/../src/lib/python/isc/notify/tests/notify_out_test.py",
line 346, in test_init_notify_out
self._notify._notify_infos[('example.com.', 'IN')].notify_slaves)
AssertionError: Lists differ: [('3.3.3.3', 53), ('4:4::4:4',... != []
First list contains 3 additional elements.
First extra element 0:
('3.3.3.3', 53)
- [('3.3.3.3', 53), ('4:4::4:4', 53), ('5:5::5:5', 53)]
+ []
----------------------------------------------------------------------
Ran 16 tests in 0.058s
}}}
I guess a test file is missing from some variable of Makefile.am.
--
Ticket URL: <http://bind10.isc.org/ticket/1288#comment:17>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list