BIND 10 #1332: Implement ZoneJournalReader class

[BIND 10 Development]

#1332: Implement ZoneJournalReader class
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  5
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 There are few notes I have:
  * I believe the correct word is „track“, not „truck“
 {{{
 implementation is assumed to keep truck of sufficient history to
 }}}
  * The text of the exception has two prepositions in a row (for in).
 {{{#!c++
     virtual std::pair<ZoneJournalReader::Result, ZoneJournalReaderPtr>
     getJournalReader(const isc::dns::Name&, uint32_t, uint32_t) const {
         isc_throw(isc::NotImplemented, "Journaling isn't supported for "
                   "in Nop data source");
         //return (ZoneJournalReaderPtr());
     }
 }}}
  * Why is the return left there commented out? I guess it should be
 removed.
  * If the comment is true, why is it a TYPED_TEST?
 {{{#!diff
 @@ -2870,76 +2969,79 @@ TEST_F(MockDatabaseClientTest, journalMultiple) {
   *
   * Note that we implicitly test in different testcases (these for add and
   * delete) that if the journaling is false, it doesn't expect the order.
 + *
 + * In this test we don't check with the real databases.
   */
 -TEST_F(MockDatabaseClientTest, journalBadSequence) {
 +TYPED_TEST(DatabaseClientTest, journalBadSequence) {
 }}}
  * The journalReader test doesn't check it successfully got any reader
 back or that the result is SUCCESS.
  * Is it OK with our style guidelines to check by ASSERT_TRUE and
 ASSERT_FALSE if the shared pointer is NULL or not?
  * The database is expected to hold if a given diff is addition or
 removal. Why doesn't the interface provide this information? One comment
 says that an application might want to explicitly check that it is correct
 IXFR sequence, but it can't really do so without this information.

 Thank you

-- 
Ticket URL: <http://bind10.isc.org/ticket/1332#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development