BIND 10 #1342: Reintroduce delayed restarts after #213

[BIND 10 Development]

#1342: Reintroduce delayed restarts after #213
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jelte
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20111122
                   Priority:  major  |            Resolution:
                  Component:  Boss   |             Sensitive:  0
  of BIND                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Replying to [comment:7 jelte]:
 > Turns out with the changes from 213, it's actually easier to implement
 this, so I've removed the legacy scheduler class and let the component
 class handle it's own restarting.
 >
 > Behaviour of restarts changed slightly; it'll now be restarted X seconds
 (default 10) after time of start, not time of death. But the calculation
 of restart time is in its own method so we can easily change the
 algorithm.

 I think that this actually was the original behavior, not 10s after the
 death, but 10s after the original start. Anyway, this doesn't seem very
 important.

 I fixed the boss tests to pass (and pushed), as you removed the
 dead_processes variable.

 I guess you see no way to test the boss code itself as unittest? Anyway,
 you might want to check how components interacts with various kinds and
 being killed sooner or later.

 Actually, I found a problem with the behaviour. If I choose a needed
 component (let's say b10-auth in the default configuration) and kill it
 later than 10s after the system started, it is restarted. If I kill it
 again soon afterwards, the system stops. However, the semantics of needed
 component was to stop only if it fails at startup (with 10s being large
 enough time to fit the initialization in there probably), when the user
 typed the command and can see the system is ill. But this might happen
 after the user went for a holiday, so in this case it shouldn't bring the
 system down.

 Also, what is the purpose of the restart_delay parameter? Nothing uses it.

 And, the description of this parameter is misleading. It assumes the
 component is restarted every time, no matter if the component might be
 core for example.

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/1342#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development