BIND 10 #1359: reference leak in python log wrapper

[BIND 10 Development]

#1359: reference leak in python log wrapper
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20111122
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  logging                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by stephen):

 > BTW, this is totally unrelated to this ticket, but I've been also
 noticing that in the python log wrapper converts the expensive conversion
 from objects to string for all log levels. I guess this has non negligible
 performance impact even if performance is relatively less crucial for
 python programs. I wonder whether we should do the isXXXEnabled() check in
 Logger_debug(), etc, before calling Logger_performOutput. Would that be
 worth trying, maybe in a separate ticket?
 I think so.  In the C++ code we were worried about the overhead of
 evaluating the arguments passed to  logger.debug() even if nothing was
 going to be output, since these may involve expensive operations (e.g.
 conversion to a string).  That's why the LOG_XXX macros came about: these
 do precisely what you suggest, i.e. calling isXXXEnabled() and doing
 nothing (not even evaluating arguments) if it returns false.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1359#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development