BIND 10 #1342: Reintroduce delayed restarts after #213
BIND 10 Development
do-not-reply at isc.org
Thu Nov 17 11:45:31 UTC 2011
#1342: Reintroduce delayed restarts after #213
-------------------------------------+-------------------------------------
Reporter: | Owner: vorner
vorner | Status: reviewing
Type: | Milestone:
defect | Sprint-20111122
Priority: major | Resolution:
Component: Boss | Sensitive: 0
of BIND | Sub-Project: Core
Keywords: | Estimated Difficulty: 4
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => vorner
Comment:
Replying to [comment:11 vorner]:
> Replying to [comment:10 jelte]:
> > Replying to [comment:9 vorner]:
>
> In the second sentence, I meant more like the stuff in
lib/python/isc/bind10/components.py. There are quite few changes, but not
many tests for it. There should be something to see that if it is
restarted, the _original_start_time isn't changed, that it is None before
the first start, the starts sets it, that a core component doesn't get
restarted or return True, etc.
>
Ah, yes, of course. I updated a number of the tests (added the return
value checks to them) and made a separate once for the start time thingy.
I also found and fixed a bad test that wasn't executed because it was
hidden by another test with the same name ('needed' was used when it
should've been 'dispensable').
Some additional fooling around also brought to light something I didn't
know about python; default values for optional parameters are only
evaluated once, which is why originally the time.time() in the tests hack
didn't work for me. Also fixed that and updated the tests
> >
> > Heh. I *knew* it was too convenient that that variable existed already
> > :)
>
> :-)). Well, I heard one should be wary about the things that come for
free ;-).
hear hear :)
--
Ticket URL: <http://bind10.isc.org/ticket/1342#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list