BIND 10 #1333: Add python wrappers of the updates to ZoneUpdater and ZoneJournalReader
BIND 10 Development
do-not-reply at isc.org
Fri Nov 18 17:16:01 UTC 2011
#1333: Add python wrappers of the updates to ZoneUpdater and ZoneJournalReader
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20111122
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:17 vorner]:
Thanks for the review.
> It looks mostly OK, I noticed only two things (hopefully not because I'm
sleepy now):
> * This seems to be leftover comment from the generator which could be
removed?
> {{{#!c++
>
> // Enable this if you use s# variants with PyArg_ParseTuple(), see
> // http://docs.python.org/py3k/c-api/arg.html#strings-and-buffers
> //#define PY_SSIZE_T_CLEAN
> }}}
I was aware that but intentionally left it there in case we'll need it
in a future extension. But now that you've pointed out, maybe it's
less confusing to just clean it up for now. So I did it.
> * What is the purpose of this tearDown?
> {{{#!python
> def tearDown(self):
> self.dsc = None
> self.reader = None
> }}}
I clarified this in an added comment:
{{{#!python
def tearDown(self):
# Some tests leave the reader in the middle of sequence, holding
# the lock. Since the unittest framework keeps each test object
# until the end of the entire tests, we need to make sure the
reader
# is released at the end of each test. The client shouldn't do
harm
# but we clean it up, too, just in case.
self.dsc = None
self.reader = None
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/1333#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list